Skip to content

Conversation

@maxkarlsson
Copy link
Collaborator

@maxkarlsson maxkarlsson commented Dec 9, 2025

Description

  • The ES now tolerates chunk errors and will in most cases render a report even if some chunks fail.

Fixes: PNA-1765

Type of change

  • Bug fix

How Has This Been Tested?

Manual tests.

PR checklist:

  • I have run R CMD check on the package and it passes.
  • I have made changes to the documentation.
  • I have added tests.
  • I have documented any significant changes in CHANGELOG.md

@maxkarlsson maxkarlsson marked this pull request as ready for review December 9, 2025 17:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables error tolerance in Quarto report rendering by adding error: true to execution options across multiple report template files. This allows reports to render successfully even when individual code chunks encounter errors, addressing issue PNA-1765.

Key Changes:

  • Added YAML front matter with execution options to 5 child template files
  • Set error: true in the main template file to propagate error tolerance
  • Standardized execution configuration (ragg_png device, suppressed warnings/messages/echo) across all templates

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
inst/quarto/spatial.qmd Added YAML front matter with error tolerance enabled
inst/quarto/quality_metrics.qmd Added YAML front matter with error tolerance enabled
inst/quarto/preprocessing.qmd Added YAML front matter with error tolerance enabled
inst/quarto/pixelatorES.qmd Added error: true to existing execution options
inst/quarto/cell_annotation.qmd Added YAML front matter with error tolerance enabled
inst/quarto/abundance.qmd Added YAML front matter with error tolerance enabled

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

---
execute:
dev: ragg_png
execute-dir: dir
Copy link

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The value 'dir' for execute-dir is ambiguous. Consider using a more descriptive name like 'project' or documenting what this refers to, as it's unclear whether this is a placeholder or an actual directory name.

Suggested change
execute-dir: dir
execute-dir: project

Copilot uses AI. Check for mistakes.
@maxkarlsson maxkarlsson merged commit 65e9b42 into main Dec 10, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants