fix: package versioning #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code only worked if you launched the bot using npm, but if you launch using any other launchers / supervisors, it wont display the correct version. Fixes by importing package.json and reading the version off from it.
i think idk im running this on web not locally, so cant tell lmfao
Member
|
Thank you for this! I’ll keep tabs on this |
Contributor
|
Ok |
Member
|
Got around to fixing this. The GitHub Build is failing due to a bug with the workflow, but it works on my local version now, so I'm going to merge it now. Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code only worked if you launched the bot using npm, but if you launch using any other launchers / supervisors, it wont display the correct version.
Fixes by importing package.json and reading the version off from it.
npm run lintWIP