Make responsiveness of LanguageServerRouter main loop configurable …
#405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…via parameter `loopIterationDelay`
Member
|
OSX CI failure looks related |
Contributor
Author
In what way does it look related?
Can you please elaborate? |
Member
|
you are right, that change wouldn't cause it to break, although unluckily it was breaking in the test that was testing basic LSP I/O lol Will retry once the linux tests are finished, but the runner seems to have hanged up. |
Contributor
Author
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…via parameter
loopIterationDelay. I recommend defaultingloopIterationDelayto something way smaller than the current default being10.msecsin order to make fibers with high yield frequency not being blocked by the call toThread.sleepin the mainloop which is the reason why I'm creating this PR.Exstensive integration tests with many test round trips wants
loopIterationDelayto be minimal. For our use case I prefer about10.nsecs-100.nsecs.