Fix trades drawdown calculation #9249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredbroad
reviewed
Jan 29, 2026
| // \ / | ||
| // \ / | ||
| // \/ | ||
| // We expect a drawdown of 20 (from 70 to 90 which is higher than the first one from 100 to 110) |
…duced trade grouping methods
Martin-Molinero
approved these changes
Jan 30, 2026
Martin-Molinero
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix trades drawdown (
Trade.EndTradeDrawdown) calculation.Related Issue
Related to #9234
Motivation and Context
Requires Documentation Change
How Has This Been Tested?
Unit tests
Types of changes
Checklist:
bug-<issue#>-<description>orfeature-<issue#>-<description>