Skip to content

Conversation

@joyeamd
Copy link
Contributor

@joyeamd joyeamd commented Dec 26, 2025

Proposed changes

  1. Spilt weight preshuffled pipeline into 3 files: representing pipeline, block, warp level.
  2. Unify LDS buffer management API for single and double buffering modes by:
    • Merging single and double LDS buffer APIs into a unified interface
    • Implementing ping-pong address calculation in pipeline when double LDS is enabled
    • Computing pong buffer addresses dynamically using base address offsets

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

joyeamd and others added 6 commits January 5, 2026 08:23
Unify LDS buffer management API for single and double buffering modes

This change consolidates the Local Data Store (LDS) buffer management by:

Merging single and double LDS buffer APIs into a unified interface
Implementing ping-pong address calculation in pipeline when double LDS is enabled
Computing pong buffer addresses dynamically using base address offsets

---------

Co-authored-by: joye <joye@amd.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@joyeamd joyeamd force-pushed the joye/revise_wp_pipeline branch from e8d7dcc to d0e2785 Compare January 5, 2026 00:28
@ThomasNing ThomasNing merged commit 2b563ad into develop Jan 5, 2026
21 checks passed
@ThomasNing ThomasNing deleted the joye/revise_wp_pipeline branch January 5, 2026 21:49
@afagaj afagaj changed the title Joye/revise wp pipeline Refactor weight preshuffled pipeline and unify LDS buffer management API Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants