Skip to content

Fix outdated docker volume instructions #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ethanknights wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix outdated docker volume instructions #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
432bac7
pg docker volume name Update README.md
ethanknights Aug 12, 2024
6727d07
update docker pgdata volume in docs
ethanknights Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ setup:
stage: setup
script:
- cd envs/dev
- docker volume create vol_smart_pgdata && docker volume create vol_smart_data
- docker volume create vol_smart_pgdata_15_2 && docker volume create vol_smart_data
- docker-compose up -d
after_script:
- cd envs/dev
Expand Down Expand Up @@ -54,6 +54,6 @@ cleanup:
script:
- cd envs/dev
- docker-compose down
- docker volume remove vol_smart_pgdata
- docker volume remove vol_smart_pgdata_15_2
- docker volume remove vol_smart_data
when: always
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ docker-compose build
Next, create the docker volumes where persistent data will be stored.

```bash
docker volume create --name=vol_smart_pgdata
docker volume create --name=vol_smart_pgdata_15_2
docker volume create --name=vol_smart_data
```

Expand Down
2 changes: 1 addition & 1 deletion smart-docs/docs/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Quick Start
$ git clone https://github.com/RTIInternational/SMART.git
$ cd smart/envs/dev/
$ docker-compose build
$ docker volume create --name=vol_smart_pgdata
$ docker volume create --name=vol_smart_pgdata_15_2
$ docker volume create --name=vol_smart_data
$ docker-compose run --rm backend ./migrate.sh
$ docker-compose up -d
Expand Down
4 changes: 2 additions & 2 deletions smart-docs/docs/tutorial-installation.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ SMART uses Docker in development to aid in dependency management. First, install
$ cd smart/envs/dev
$ docker-compose build

Next, create the docker volumes where persistent data will be stored: ``docker volume create --name=vol_smart_pgdata`` and ``docker volume create --name=vol_smart_data``.
Next, create the docker volumes where persistent data will be stored: ``docker volume create --name=vol_smart_pgdata_15_2`` and ``docker volume create --name=vol_smart_data``.

::

$ docker volume create --name=vol_smart_pgdata
$ docker volume create --name=vol_smart_pgdata_15_2
$ docker volume create --name=vol_smart_data

Then, migrate the database to ensure the schema is prepared for the application.
Expand Down