Ux issues #587
Ux issues #587
Conversation
… admins per group.
There was a problem hiding this comment.
Pull Request Overview
This pull request removes UK SIS (Student Information System) integration functionality from the ReCodEx system. The changes eliminate SIS-specific components, reducers, selectors, and pages while updating some related UI elements and fixing minor issues.
- Complete removal of SIS integration components, forms, and containers
- Removal of SIS-related Redux modules, selectors, and actions
- Updates to group management to use external attributes instead of SIS-specific fields
- Minor UI improvements including spelling corrections and icon usage fixes
Reviewed Changes
Copilot reviewed 86 out of 87 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/redux/selectors/ | Removes all SIS-related selectors (sisTerms, sisSupervisedCourses, etc.) |
| src/redux/modules/ | Removes SIS Redux modules and updates groups module to remove SIS dependencies |
| src/pages/ | Removes SisIntegration page and related route configuration |
| src/components/ | Removes SIS integration forms, components and updates GroupInfoTable for external attributes |
| src/containers/ | Removes SIS-specific containers |
| src/locales/ | Removes SIS-related localization strings |
| Various forms | Updates SubmitButton default icon from SendIcon to SaveIcon and adds SendIcon to specific forms |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| const exericsesAuthorsOfGroupSelector = groupId => state => state.exercisesAuthors.getIn(['groups', groupId]); | ||
|
|
||
| export const getAllExericsesAuthors = createSelector( | ||
| export const getAllExercisesAuthors = createSelector( |
There was a problem hiding this comment.
The function names contain a typo: 'getAllExericsesAuthors' and 'getAllExericsesAuthorsIsLoading' should be 'getAllExercisesAuthors' and 'getAllExercisesAuthorsIsLoading'. The variable name 'exericsesAuthorsAllSelector' also contains the same typo.
| ); | ||
|
|
||
| export const getAllExericsesAuthorsIsLoading = createSelector([exericsesAuthorsAllSelector], authors => | ||
| export const getAllExercisesAuthorsIsLoading = createSelector([exericsesAuthorsAllSelector], authors => |
There was a problem hiding this comment.
The function names contain a typo: 'getAllExericsesAuthors' and 'getAllExericsesAuthorsIsLoading' should be 'getAllExercisesAuthors' and 'getAllExercisesAuthorsIsLoading'. The variable name 'exericsesAuthorsAllSelector' also contains the same typo.
| const validateFileExists = (data, errors, path, existingFiles) => { | ||
| if (!existingFiles) { | ||
| return; // safeguard if the suplementary files are not loaded yet | ||
| return; // safeguard if the supplementary files are not loaded yet |
There was a problem hiding this comment.
Fixed spelling from 'suplementary' to 'supplementary'.
| const DEFAULT_ICON = ['far', 'square']; | ||
|
|
||
| const clickEventDisipator = ev => ev.stopPropagation(); | ||
| const clickEventDissipator = ev => ev.stopPropagation(); |
There was a problem hiding this comment.
Fixed spelling from 'Disipator' to 'Dissipator' in the function name.
| invalid={invalid} | ||
| dirty={dirty} | ||
| hasSuceeded={submitSucceeded} | ||
| hasSucceeded={submitSucceeded} |
There was a problem hiding this comment.
Fixed typo from 'hasSuceeded' to 'hasSucceeded' in the prop name.
| invalid={invalid} | ||
| dirty={dirty} | ||
| hasSuceeded={submitSucceeded} | ||
| hasSucceeded={submitSucceeded} |
There was a problem hiding this comment.
Fixed typo from 'hasSuceeded' to 'hasSucceeded' in the prop name.
No description provided.