-
Notifications
You must be signed in to change notification settings - Fork 141
Dev: Roll back train and base for Pick_Place RL training #729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Anchor1021
wants to merge
41
commits into
RoboVerseOrg:develop
Choose a base branch
from
HanchuZhou:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d hard-coded path in track.py
for more information, see https://pre-commit.ci
…n create less number of environment in evaluation
…d hard-coded path in track.py
…n create less number of environment in evaluation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Updated the devcontainer configuration with new settings, including service name, workspace folder, and VSCode customizations.
…690; v_max in banana.yaml; isaacgym.py bugfix.
…dd banana2; Set the rotation_tracking weight to 0
…banana2; Set rotation_tracking weight to 0;
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
change if self.scenario.gs_scene.with_gs_background and self.gs_background is not None:
to if self.scenario.gs_scene is not None and self.scenario.gs_scene.with_gs_background and self.gs_background is not None:
Type of change
How to test
Please check two README.md files in roboverse_learn/rl/fast_td3 and roboverse_pack/tasks/pick_place.
Screenshots / Videos
Please attach before and after screenshots or videos of the change if applicable.
Checklist
pre-commitchecks withpre-commit run --color=always --all-filesCONTRIBUTORS.mdor my name already exists there