Forward rustc warnings #488
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firestar99
force-pushed
the
fwd_warnings
branch
from
3ee0a55 to
195417a
Compare
Firestar99
commented
Dec 15, 2025
Comment on lines
743
to
783
| if self.print_metadata == MetadataPrintout::Full { | ||
| println!("cargo:rustc-env={}={}", env_var, spirv_module.display()); | ||
| if self.build_script.env_shader_spv_path() { | ||
| println!( | ||
| "cargo::rustc-env=SHADER_SPV_PATH={}", | ||
| spirv_module.display() | ||
| ); |
Member
Author
There was a problem hiding this comment.
Since I'm already changing this part, I've considered adding some more ways to "send" the shader binaries from the build script into the source code, like multimodule support for env vars or better source code gen. But I feel like exploring that would be better in a followup PR.
Member
Author
There was a problem hiding this comment.
Note: the code is outdated, I decided to go back on renaming the env var to SHADER_SPV_PATH since it breaks the android build
Firestar99
force-pushed
the
fwd_warnings
branch
from
195417a to
b8e45e4
Compare
Firestar99
force-pushed
the
fwd_warnings
branch
from
b8e45e4 to
f54d1c7
Compare
Firestar99
force-pushed
the
fwd_warnings
branch
from
f54d1c7 to
8b83d58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enum MetadataPrintoutwithstruct BuildScriptConfigfor more flexibilityspirv_builder.build_script.defaultsallows us to add new options like below in the futureMetadataPrintout::DependencyOnlyis nowspirv_builder.build_script.dependency_info = Some(true)and defaults tospirv_builder.build_script.defaults(property above)MetadataPrintout::Fullis nowspirv_builder.build_script.env_shader_spv_path = Some(true)and defaults tofalse(preventing conflicts with multimodule)cargo::warning={})Example error
Image cause github doesn't support ansi in code blocks. Also note how in the shader warning, the final "
space-engine-shader(lib) generated 1 warning" is missing. This is due tocargo --quietalso suppressing those, next to the other status messages.close #346
close Rust-GPU/cargo-gpu#103