Skip to content

Conversation

@baloo
Copy link
Member

@baloo baloo commented Dec 23, 2025

#[derive(ZeroizeOnDrop)] was throwing warnings like:

warning: value assigned to `curve` is never read
  --> src/crypto/ecdsa.rs:43:9
   |
43 |         curve: ECCCurve,
   |         ^^^^^
   |
   = help: maybe it is overwritten before being read?
   = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by de

This changes the tests to highlight the new warnings.

This changes the tests to highlight the new warnings
@baloo
Copy link
Member Author

baloo commented Dec 23, 2025

If possible, a zeroize_derive 1.5.1 release with that PR would be appreciated!

@tarcieri tarcieri merged commit 5ed71ac into RustCrypto:master Dec 24, 2025
24 checks passed
@tarcieri
Copy link
Member

@baloo hmm, 1.5.0 is still unreleased, and includes an MSRV bump

We should probably get new releases of zeroize and zeroize_derive with that bump out, though I expect some pushback.

@baloo
Copy link
Member Author

baloo commented Dec 24, 2025

Ha, right! I didn't even check.

Maybe I should backport this to 1.4 then.

@baloo baloo deleted the push-pvwuswvwvzzm branch December 24, 2025 21:29
baloo added a commit to baloo/utils that referenced this pull request Dec 24, 2025
@baloo
Copy link
Member Author

baloo commented Dec 24, 2025

I don't really have a way to open a PR for a backport because there is no branch to target to.

I've made a commit:

If you could push a 1.4.3, that would be appreciated!

I've checked that commit on rpgp (and 1.92), and it doesn't report any warnings anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants