Skip to content

Conversation

@diegomartinez2
Copy link
Contributor

Hi Lorenzo, I need somebody to test the meson install in other computers before adding it to master. I only tested in my laptop on a conda env, but it already has SSCHA in the base system so I have doubts. I think it will work on Apple ARM (M1/M2) architecture, but I do not have way to test it.
Meson_compiler_test

diegomartinez2 and others added 30 commits October 18, 2023 15:19
@mesonepigreco mesonepigreco self-requested a review September 19, 2025 11:55
@mesonepigreco mesonepigreco added the Cleaning Clean the code or solve small issues that are not bug label Sep 19, 2025
@mesonepigreco mesonepigreco added this to the version 2.0 milestone Sep 19, 2025
@mesonepigreco
Copy link
Collaborator

Hi Diego, I'll take a look at it.
The autotest is working; however, looking at the output of the installation, I find the following:

image

It is still using distutils for the installation, which is, indeed, present in your setup.py file, lines 2 and 3.
How is the meson installation performed? In any case, if the setup.py is no more needed, delete it, I can change the workflow to use instead the pip install .

@diegomartinez2
Copy link
Contributor Author

../../meson.build:76:15: ERROR: Command /opt/hostedtoolcache/Python/3.11.13/x64/bin/python -c 'import numpy; print(numpy.get_include())' failed with status 1.
So it fails at the 'import numpy' command in python?
So it needs numpy in the 'pip' configuration.

@diegomartinez2
Copy link
Contributor Author

Missing a MODULE symph in the Fortran code?.
I don't know what happens here.

@diegomartinez2
Copy link
Contributor Author

OK, this works.
On monday or so I'll fix python-sscha.

@mesonepigreco
Copy link
Collaborator

Ok thank you very much, I am testing it right now on my computer. If it works we can try to release the 1.5 with this, that should fix all the installation errors.

I am trying with python 3.12 which should be the aim of the meson fix.

Copy link
Collaborator

@mesonepigreco mesonepigreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Diego, thanks, it works correctly.

Can you update the installation guide as I mentioned in the review, so that we can point to python 3.12, and avoid the mandatory gfortran installation if we work in a conda enviroment (move that in the later section on manual compilation)?
Also note that to have meson work with mamba it requires installing pkg-config from mamba/conda, otherwise it does not detect BLAS.
Maybe you can add my custom command to install cellconstructor.

Copy link
Collaborator

@mesonepigreco mesonepigreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we are ready to merge

@mesonepigreco mesonepigreco merged commit 4091e3c into SSCHAcode:master Sep 29, 2025
2 checks passed
@mesonepigreco
Copy link
Collaborator

Thank you very much @diegomartinez2
Can you also do it for python-sscha? So we can release version 1.5 and finally fix this major issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cleaning Clean the code or solve small issues that are not bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants