Skip to content

Conversation

@Himura2la
Copy link
Contributor


name: Pull Request
about: Submit a pull request to Dockerify Android
title: 'Support Windows environment'
labels: ''
assignees: ''


Description

Fix the /root/start-emulator.sh: line 2: $'\r': command not found error

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update

How Has This Been Tested?

Re-clone the repo, rebuild an image and try to up the compose file once again.

the CRLF error is gone, but I'm stuck a bit further, presumably due to insufficient RAM.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Fix the `/root/start-emulator.sh: line 2: $'\r': command not found` error
@Himura2la Himura2la changed the title Support Windows environment Support Podman desktop on Windows environment Aug 11, 2025
@Shmayro Shmayro requested a review from Copilot August 26, 2025 07:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes Windows compatibility issues by configuring Git to handle line endings properly, addressing the /root/start-emulator.sh: line 2: $'\r': command not found error that occurs when Windows CRLF line endings are used in shell scripts.

  • Adds a .gitattributes file to enforce LF line endings for all files

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Owner

@Shmayro Shmayro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@Shmayro Shmayro merged commit 92e2c8f into Shmayro:main Aug 26, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants