Skip to content

Conversation

@Stateford
Copy link
Owner

…er styles and improve borderless window handling

…er styles and improve borderless window handling
Copilot AI review requested due to automatic review settings January 19, 2026 02:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request enhances window management functionality by refactoring the borderless window handling. The changes improve how window border styles are removed and restored, replacing toggle-based operations with explicit remove and restore functions.

Changes:

  • Refactored borderless window operations from XOR-based toggling to explicit style removal and restoration
  • Added tracking of extended window styles (previousExStyle) for proper restoration
  • Added SWP_FRAMECHANGED flags to ensure Windows properly applies style changes
  • Fixed a typo in a code comment

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/components/win.c Refactored window border management: replaced toggleBorderlessWindow with removeBorderStyles and restoreBorderStyles functions, improved style restoration logic, and added proper frame change notifications
.claude/settings.local.json Added a developer-specific test executable path

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 10 to 11
"Bash(xxd:*)",
"Bash(\"C:\\\\Users\\\\japos\\\\git\\\\Display-Lock\\\\build\\\\tests\\\\Debug\\\\display-lock-unittests.exe\")"
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line adds a developer-specific absolute path containing a username. The .local.json suffix suggests this file should contain local developer settings that shouldn't be committed to version control. Consider adding this file to .gitignore or removing this developer-specific path from the committed version.

Suggested change
"Bash(xxd:*)",
"Bash(\"C:\\\\Users\\\\japos\\\\git\\\\Display-Lock\\\\build\\\\tests\\\\Debug\\\\display-lock-unittests.exe\")"
"Bash(xxd:*)"

Copilot uses AI. Check for mistakes.
@Stateford Stateford merged commit ede827b into master Jan 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants