fix(input): Fix double-click fast drive timing in ParticleUplinkCannon

[bobtista]

Closes #2011

Testing (TODO)

Fast drive mode activation via double-click now works consistently at any frame rate and logic time scale setting.

[stephanmeesters]

I could do a bit of testing and review for this

For both 30hz and 60hz :

• double click to activate fast beam should feel the same
• after activating fast beam the trajectory should be the same
• make a save game right after activating the fast beam then check if the trajectory is the same (for tsh regular and retail compatible versions)
• load a retail savegame and check that the beam trajectory is the same as in the retail version

Does that seem right?

[Caball009]

m_lastDrivingClickTimeMsec != 0 && m_2ndLastDrivingClickTimeMsec != 0
Do we need to check this?

[bobtista]

If either of them are 0 we could get weird results right? Eg huge timestamp - 0 = big number, and if both are, 0 - 0 = 0.

[Caball009]

Doesn't that also apply to the original code with frame numbers?

[bobtista]

Oh right, yes, added the null checks to the RETAIL_COMPATIBLE_CRC code too

[Caball009]

I still don't understand why it's needed, though. Is there a bug without this in the original code, or does the change to msec make it necessary to have these != 0 checks?

[bobtista]

Replicated to Generals in the most recent commit, which differs slightly and is worth giving a quick look

[stephanmeesters]

Tested this by making a savegame of a skirmish at max gamespeed, then loaded it back at regular gamespeed. Trajectory of the beam and beam duration appeared the same also using fast drive

Using the compatibility flags I loaded a retail gamesave, and also saved a game and loaded that in retail. That works fine

---

I thought it would be interesting to test 30hz and 60hz with the same gamespeed the way GO does it, stephanmeesters@7491c32

Double click felt the same, trajectory and duration the same

It did have problems with the replay as the beam duration was no longer the same, but the gametime was also reported wrong, so that's probably just because I hacked that GO code in