fix(xfer): Fix xfer retail compatibility code #2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
added
Minor
xezon
commented
Dec 21, 2025
| // For retail game compatibility, this transfers the loaded visual laser radius | ||
| // settings from the Drawable's LaserUpdate to the local LaserRadiusUpdate. | ||
| if( m_orbitToTargetBeamID != INVALID_DRAWABLE_ID ) | ||
| if (m_xferVersion <= 3) |
Author
There was a problem hiding this comment.
Here I replaced
#if RETAIL_COMPATIBLE_XFER_SAVE with if (m_xferVersion <= 3)
because it makes no sense to only do this load correction when RETAIL_COMPATIBLE_XFER_SAVE is compiled in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a review pass on our
RETAIL_COMPATIBLE_XFER_SAVEcode and identified a few things that needed improving.