일반 회원 가입 API 개선 #83
Open
일반 회원 가입 API 개선 #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add accounts table. - modify members table.
- Moved checkUsernameAPI logic and tests from user domain to auth domain. - Updated endpoint.
- Changed password column in accounts table to be nullable.
- Drop foreign key constraint to accounts table from members table.
- Modified RegisterMember API to accommodate the separation of member and account entities. - Updated data handling and validation processes to align with the new structure. - Made minimal changes to the login API to ensure basic functionality; further logic improvements are needed.
- added "DROP FUNCTION IF EXISTS generate_unique_hash_code".
Open
Resilient923
approved these changes
Oct 13, 2024
Resilient923
left a comment
Resilient923
left a comment
There was a problem hiding this comment.
다행히도 저랑 코드 짜는 스타일이 비슷하신 것 같아요 션~!
다른 부분은 특이사항 없는 것 같습니다.
| import com.titi.titi_auth.data.jpa.entity.AccountEntity; | ||
| import com.titi.titi_auth.domain.Account; | ||
|
|
||
| @Mapper |
There was a problem hiding this comment.
P5(라고써야하나요..? 저 회사에서는 잡담은 그냥 P를 안붙이곤 합니다ㅎㅎ) : 오 Mapper 어노테이션 사용은 처음이네요
Contributor
Author
There was a problem hiding this comment.
저희 P1~P3만 사용하기로 얘기했던 것 같아요. Pn은 안쓰고 Request changes/Comment/Approve로 구분하면 될 것 같네요 ㅎㅎ
| } | ||
|
|
||
| private void validatePassword(String rawPassword, Member member) { | ||
| /*private void validatePassword(String rawPassword, Member member) { |
There was a problem hiding this comment.
P5 : 주석을 달아놓은 코드들은 추후사용 예정이나 다른 목적이 있으신걸까요?
Contributor
Author
There was a problem hiding this comment.
위 참고 사항 부분에 적어놓은 부분이 여기에요. 로그인 부분 개발할 때 변경될 부분입니다.
Contributor
Author
|
회원 정보 검증 조건 논의 결과에 따라, Nickname, Username, Password 검증식을 변경할 예정이에요.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍋 개요
🍊 변경 사항
🥨 참고 사항
🍏 체크리스트
CTRL+ALT+L)은 완료하였나요?구현을 모두 완료하였나요?Test Code는 모두 작성하였나요?Commit Message는 충분히 자세하게 작성되었나요?Assignees,Label은 적용하였나요?