[ACL-158] Supports specifying authorization_flow and hosted_page when creating a payment #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dili91
commented
Dec 19, 2025
Comment on lines
+12
to
14
| // TODO: can this be deprecated? We should leverage the HPP URI generated by the payments-gateway instead. | ||
| // note that deprecating would probably mean creating a new type for our test utils | ||
| PAYMENT("payments", "payment_id", HPP), |
dili91
commented
Dec 19, 2025
|
|
||
| // HTTP client | ||
| def retrofitVersion = '2.9.0' | ||
| def retrofitVersion = '3.0.0' |
Contributor
Author
There was a problem hiding this comment.
This is huge and to be validated. They have updated the underlying OkHTTP version
dili91
force-pushed
the
create-payment-improvements
branch
from
ba17015 to
5501269
Compare
dili91
force-pushed
the
create-payment-improvements
branch
from
5501269 to
5d87394
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a sufficiently detailed description of your changes
[Fixes # (issue)]
Type of change
Please select multiple options if required.
Checklist:
gradle.propertiesfile with the new versionCHANGELOG.mdfile with the details of the new version