Fix incorrect const qualifier in membuf.pyx #1397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, I see errors when building netCDF4-python,
originating at the line `free(self.memory)` in `__dealloc__()`:
.../_cython/_netCDF4.cc:12922:3: error: no matching function for call to 'free'
12922 | free(__pyx_v_self->memory);
| ^~~~
.../include/stdlib.h:563:13: note: candidate function not viable: 1st argument ('const void *') would lose const qualifier
563 | extern void free (void *__ptr) __THROW;
| ^ ~~~~~~~~~~~
Apparently it is not valid call `free()` on a `const` variable.
Collaborator
|
MPI tests are failing, but that's unrelated. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, I see errors when building netCDF4-python, originating at the line
free(self.memory)in__dealloc__():Apparently it is not valid to call
free()on aconstvariable.