Skip to content

Conversation

@Pauliusd01
Copy link
Collaborator

@Pauliusd01 Pauliusd01 commented Jan 13, 2026

Description

Adds some packages to the Preview APV ignore list. The one for com.unity.charactercontroller is temporary, there's another solution on their end in flight but it might take a while. Should be removed next release

Testing status & QA

Ran All Preview APV job and it passed

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity:
  • Halo Effect:

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@u-pr-agent
Copy link
Contributor

u-pr-agent bot commented Jan 13, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

Single-line change to a version constraint; quick to validate expected matching behavior and any downstream consumers.
🏅 Score: 92

Small, clear change, but it needs confirmation that the new version range string is interpreted as intended by the `Editor` version-matching logic.
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Version Match

Confirm that the Editor constructor and any version parser correctly interpret the string constraint format using a range expression so the ignore list applies to all intended 6000.3+ preview versions (and does not unintentionally match/skip other versions).

// ignore packages listed below in PreviewAPV
InputSystemPackage.DependantsToIgnoreInPreviewApv = new Dictionary<Editor, ISet<string>>()
{
    {
        new Editor(">=6000.3",  ""),
        new HashSet<string>()
        {
            "com.unity.polyspatial",
            "com.unity.polyspatial.visionos",
  • Update review

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent

@u-pr-agent
Copy link
Contributor

u-pr-agent bot commented Jan 13, 2026

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Avoid version ranges in keys

Ensure Editor supports range expressions like ">=6000.3"; if it expects a plain
version, this will break dictionary keying and matching. Prefer a dedicated
range/constraint type (or explicit min/max fields) so comparisons are semantic
rather than string-based.

Tools/CI/Settings/InputSystemSettings.cs [107]

-new Editor(">=6000.3",  ""),
+new Editor("6000.3",  ""),
Suggestion importance[1-10]: 6

__

Why: The suggestion correctly flags a potential behavioral change: if Editor (and its equality/comparison logic) does not support constraint strings like ">=6000.3", using it as a dictionary key could prevent matching and break ignore rules. However, it’s conditional/speculative and the proposed improved_code simply reverts the PR change rather than offering a semantic range solution.

Low
  • More suggestions

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent

@codecov-github-com
Copy link

codecov-github-com bot commented Jan 13, 2026

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff            @@
##           develop    #2322   +/-   ##
========================================
  Coverage    77.95%   77.95%           
========================================
  Files          476      476           
  Lines        97443    97453   +10     
========================================
+ Hits         75961    75971   +10     
  Misses       21482    21482           
Flag Coverage Δ
inputsystem_MacOS_2022.3 5.54% <ø> (ø)
inputsystem_MacOS_2022.3_project 75.47% <ø> (ø)
inputsystem_MacOS_6000.0 5.32% <ø> (ø)
inputsystem_MacOS_6000.0_project 77.36% <ø> (ø)
inputsystem_MacOS_6000.3 5.32% <ø> (ø)
inputsystem_MacOS_6000.3_project 77.36% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.4 5.32% <ø> (ø)
inputsystem_MacOS_6000.4_project 77.36% <ø> (+<0.01%) ⬆️
inputsystem_MacOS_6000.5 5.32% <ø> (ø)
inputsystem_MacOS_6000.5_project 77.36% <ø> (+<0.01%) ⬆️
inputsystem_Ubuntu_2022.3 5.54% <ø> (ø)
inputsystem_Ubuntu_2022.3_project 75.26% <ø> (ø)
inputsystem_Ubuntu_6000.0 5.32% <ø> (ø)
inputsystem_Ubuntu_6000.0_project 77.16% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.3 5.32% <ø> (ø)
inputsystem_Ubuntu_6000.3_project 77.16% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.4 5.33% <ø> (ø)
inputsystem_Ubuntu_6000.4_project 77.17% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.5 5.33% <ø> (ø)
inputsystem_Ubuntu_6000.5_project 77.17% <ø> (ø)
inputsystem_Windows_2022.3 5.54% <ø> (ø)
inputsystem_Windows_2022.3_project 75.60% <ø> (ø)
inputsystem_Windows_6000.0 5.32% <ø> (ø)
inputsystem_Windows_6000.0_project 77.49% <ø> (+<0.01%) ⬆️
inputsystem_Windows_6000.3 5.32% <ø> (ø)
inputsystem_Windows_6000.3_project 77.49% <ø> (+<0.01%) ⬆️
inputsystem_Windows_6000.4 5.32% <ø> (ø)
inputsystem_Windows_6000.4_project 77.49% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.5 5.32% <ø> (ø)
inputsystem_Windows_6000.5_project 77.50% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@josepmariapujol-unity josepmariapujol-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Approved! 🟢

@josepmariapujol-unity
Copy link
Collaborator

Waiting for CI jobs to pass :)

@Pauliusd01 Pauliusd01 merged commit 0cb3d8f into develop Jan 14, 2026
109 checks passed
@Pauliusd01 Pauliusd01 deleted the update-ignore-in-preview-list branch January 14, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants