-
Notifications
You must be signed in to change notification settings - Fork 328
FIX: Update ignored packages in Preview APV and regenerate YAML job definitions #2322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent |
PR Code Suggestions ✨Explore these optional code suggestions:
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent |
|||||||||
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2322 +/- ##
========================================
Coverage 77.95% 77.95%
========================================
Files 476 476
Lines 97443 97453 +10
========================================
+ Hits 75961 75971 +10
Misses 21482 21482 Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
josepmariapujol-unity
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Approved! 🟢
|
Waiting for CI jobs to pass :) |
Description
Adds some packages to the Preview APV ignore list. The one for com.unity.charactercontroller is temporary, there's another solution on their end in flight but it might take a while. Should be removed next release
Testing status & QA
Ran All Preview APV job and it passed
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.