add user flags to user-mgmt.php #434
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonLeary42
changed the title
simonLeary42
force-pushed
the
flags-in-user-mgmt
branch
3 times, most recently
from
dae430e to
d1434da
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the user management interface by adding user flag columns to the table, removing the restriction that only qualified users are displayed, and implementing a new column toggle feature that allows users to show/hide columns dynamically.
Key changes:
- Refactored LDAP methods to fetch all users instead of only qualified users
- Added JavaScript functionality to enable column visibility toggling via checkboxes
- Extended the user management table to display user flag data with columns hidden by default
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
webroot/js/tables.js |
Implements column toggle functionality with checkboxes for tables with the column-toggle class, allowing dynamic show/hide of columns |
webroot/admin/user-mgmt.php |
Adds user flag columns to the table, updates to use new LDAP methods that fetch all users, and applies column-toggle class to enable the new feature |
resources/lib/UnityLDAP.php |
Refactors methods to remove qualified-user-only filtering: renames getQualifiedUsersAttributes to getAllUsersAttributes and getQualifiedUID2PIGIDs to getUID2PIGIDs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
simonLeary42
force-pushed
the
flags-in-user-mgmt
branch
from
e691282 to
79286ab
Compare
Collaborator
Author
|
Needs a rework after #456 |
simonLeary42
force-pushed
the
flags-in-user-mgmt
branch
from
79286ab to
7b61014
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user-mgmt.phpfor each user flag<table>classcolumn-toggle:tables.jswill insert checkboxes for each column to toggle thedisplaystyle for thenth-childof each<tr>using jquery<th>classhidden-by-defaultScreen.Recording.2025-12-23.at.8.30.22.AM.mov