Skip to content

implement logic behind user flags #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
simonLeary42 wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

implement logic behind user flags #473

simonLeary42 wants to merge 21 commits into from

Conversation

@simonLeary42
Copy link
Collaborator

@simonLeary42 simonLeary42 commented Dec 31, 2025 •
edited
Loading

TODO:

  • documentation
  • resurrected PI pretend old PI group does not exist
  • tests:
    • ghost account is not redirected from new_account.php to account.php
    • ghost account is resurrected when they register again, message is sent
    • idle unlock works, message is sent
    • qualify works
      • admin approve
      • PI approve
    • dequalify works
      • admin remove user
      • PI remove user
      • user leave group
    • viewAsUser does not reset idlelock
    • locked works

@simonLeary42 simonLeary42 changed the title ensure not ghost on register account expiry Dec 31, 2025
@simonLeary42 simonLeary42 changed the title account expiry implement logic behind user flags Dec 31, 2025
@simonLeary42
Copy link
Collaborator Author

simonLeary42 commented Jan 2, 2026 •
edited
Loading

TODO: UserFlag is defined in UnityLDAP.php, setFlag is defined in UnityUser.php, and the calls to setFlag are in init.php, UnityGroup.php, and new_account.php. Can this be more unified?

@simonLeary42 simonLeary42 force-pushed the account-expiry branch 5 times, most recently from 72dfe3d to 3c4b4ce Compare January 5, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@simonLeary42