Skip to content

Conversation

@ncrmro
Copy link
Collaborator

@ncrmro ncrmro commented Jan 27, 2026

Summary

  • Fix claude-code-test.yml paths from .claude/commands/ to .claude/skills/
  • Remove temporary test branch references from workflow triggers
  • Clean up test files from merge queue testing

Problem

The CI tests in claude-code-test.yml were looking for generated skills in .claude/commands/ but the generator now outputs to .claude/skills/. This caused:

  • PR checks to pass (because they skip actual tests on pull_request event)
  • Merge queue checks to fail (because they run full tests on merge_group event)

This meant PRs could never successfully merge through the merge queue.

Solution

Update all path references in claude-code-test.yml from .claude/commands/ to .claude/skills/ to match the current generator output.

Test plan

  • PR checks pass (skipped tests)
  • Add to merge queue
  • Verify merge_group event triggers full tests
  • Confirm tests pass with corrected paths
  • PR merges successfully through queue

🤖 Generated with Claude Code

ncrmro and others added 4 commits January 27, 2026 11:42
This enables testing merge queue functionality without affecting main branch.
Workflows modified:
- validate.yml
- claude-code-test.yml
- cla.yml

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@ncrmro ncrmro enabled auto-merge January 27, 2026 19:33
@ncrmro ncrmro added this pull request to the merge queue Jan 27, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 27, 2026
@ncrmro ncrmro changed the base branch from test-merge-queue to main January 28, 2026 20:22
@ncrmro ncrmro added this pull request to the merge queue Jan 28, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 28, 2026
Changes:
- Fix claude-code-test.yml paths from .claude/commands/ to .claude/skills/
  (generator now outputs to skills/ directory)
- Remove test-merge-queue branch references from workflow triggers
- Remove temporary test files

This fix enables the merge queue to properly validate PRs before merging.
The CI tests were previously passing on PRs because they skip actual tests,
but would fail in the merge queue due to incorrect paths.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@ncrmro ncrmro changed the title test: Second test PR for merge queue validation fix: Update CI test paths to enable merge queue validation Jan 28, 2026
@ncrmro ncrmro added this pull request to the merge queue Jan 28, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 28, 2026
The test workflow expected flat skill files but the generator creates
skill directories. Updated all path checks from `.claude/skills/X.md`
to `.claude/skills/X/SKILL.md` format.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@ncrmro ncrmro added this pull request to the merge queue Jan 28, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 28, 2026
The --yes flag doesn't exist in the Claude CLI. The correct flag for
bypassing permission prompts in CI is --dangerously-skip-permissions.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@ncrmro ncrmro added this pull request to the merge queue Jan 28, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 28, 2026
@nhorton nhorton added this pull request to the merge queue Jan 29, 2026
github-merge-queue bot pushed a commit that referenced this pull request Jan 29, 2026
* test: Add test-merge-queue branch to workflow triggers

This enables testing merge queue functionality without affecting main branch.
Workflows modified:
- validate.yml
- claude-code-test.yml
- cla.yml

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* test: Second test PR for merge queue validation

* test: First test PR for merge queue validation (#172)

* fix: Update CI test paths and enable merge queue validation

Changes:
- Fix claude-code-test.yml paths from .claude/commands/ to .claude/skills/
  (generator now outputs to skills/ directory)
- Remove test-merge-queue branch references from workflow triggers
- Remove temporary test files

This fix enables the merge queue to properly validate PRs before merging.
The CI tests were previously passing on PRs because they skip actual tests,
but would fail in the merge queue due to incorrect paths.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix: Update CI test paths for skill directory structure

The test workflow expected flat skill files but the generator creates
skill directories. Updated all path checks from `.claude/skills/X.md`
to `.claude/skills/X/SKILL.md` format.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix: Use --dangerously-skip-permissions instead of --yes for Claude CLI

The --yes flag doesn't exist in the Claude CLI. The correct flag for
bypassing permission prompts in CI is --dangerously-skip-permissions.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 29, 2026
@ncrmro ncrmro added this pull request to the merge queue Jan 29, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants