feat(wb): add support for Vite + Playwright projects

[exKAZUu]

Summary

• Add viteScripts for handling Vite-based apps with Playwright e2e tests
• Detect Vite + Playwright projects via devDeps.vite && devDeps['@playwright/test']
• Use vite dev for development and vite preview for production testing

Test plan

• Verified with dry-run in zoom-rtms project
• Manual testing with wb test command
• CI tests pass

🤖 Generated with Claude Code

[gemini-code-assist]

Summary of Changes

Hello @exKAZUu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the wb tool by introducing comprehensive support for projects built with Vite.js and utilizing Playwright for end-to-end testing. It streamlines the development and testing workflows for such applications by automatically detecting their configuration and applying appropriate vite commands for both local development and CI environments.

Highlights

• Vite Integration: Added viteScripts to support Vite.js applications, specifically those configured with Playwright for end-to-end testing.
• Automatic Detection: Implemented logic to automatically detect Vite + Playwright projects based on the presence of vite and @playwright/test in devDependencies.
• Command Handling: Configured wb commands to use vite dev for development and vite preview for production testing, ensuring proper execution for Vite projects.
• Command Extension: Extended start, test, and testOnCi commands to incorporate the new Vite script handling.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

このプルリクエストは、Vite と Playwright を使用するプロジェクトのサポートを追加するものです。変更内容は概ね良好ですが、コードの保守性と一貫性を向上させるための改善点がいくつか見つかりました。具体的には、条件ロジックの重複と、生成されるコマンド文字列の末尾に含まれる可能性のある不要なスペースについて指摘しています。

[gemini-code-assist]

この条件式 devDeps.vite && devDeps['@playwright/test'] は、このファイルの159行目と packages/wb/src/commands/testOnCi.ts の64行目でも使用されています。コードの重複を避け、保守性を高めるために、このロジックを定数やヘルパー関数に抽出することを検討してください。

例えば、if文の前に以下のように定数を定義できます:

const isVitePlaywright = devDeps.vite && devDeps['@playwright/test'];

そして、この定数を各所で使用します。