Overhaul the Font Awesome picker #6513
Merged
+171
−184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation relied on the legacy implementation of dialogs which causes a stacking issue when opened from a new dialog. Another flaw was the abysmal accessibility because it was impossible to reach the icons with a keyboard navigation. In addition, the new implementation no longer relies on an initialization method which was used in a prior iteration.
BurntimeX
approved these changes
Nov 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation relied on the legacy implementation of dialogs which causes a stacking issue when opened from a new dialog.
Another flaw was the abysmal accessibility because it was impossible to reach the icons with a keyboard navigation.
In addition, the new implementation no longer relies on an initialization method which was used in a prior iteration.