Skip to content

Conversation

@danepowell
Copy link
Contributor

Motivation

Fixes #NNN

Proposed changes

Alternatives considered

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. If running from source, clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. Check for regressions: (add specific steps for this pr)
  4. Check new functionality: (add specific steps for this pr)

Copilot AI review requested due to automatic review settings December 16, 2025 01:49
@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.05%. Comparing base (88c9650) to head (3a63535).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1945   +/-   ##
=========================================
  Coverage     92.05%   92.05%           
  Complexity     1894     1894           
=========================================
  Files           122      122           
  Lines          6959     6959           
=========================================
  Hits           6406     6406           
  Misses          553      553           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the private network service API specification to reflect changes in the upstream API. The main changes include removing the VPC Peer update endpoint, enhancing filter parameter flexibility, simplifying HAL link schema validation, and adding tunnel address fields to VPN examples.

Key Changes:

  • Removed PUT endpoint for updating VPC Peers (endpoint no longer supported by the API)
  • Enhanced filter parameter to support both colon and equals signs as field-value separators
  • Added "address" field to VPN tunnel examples to align with the TunnelResponse schema

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
assets/acquia-spec.version Updated API specification version hash to c1a6c6733a1ec7a8d3344cc2a2390f694ab73335
assets/acquia-spec.json Removed VPC Peer PUT endpoint, updated filter parameter pattern and description, simplified HAL link href validation, and added address fields to VPN tunnel examples

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -1 +1 @@
779ca0a93e59652838a53bef74e9907f6fb53683
c1a6c6733a1ec7a8d3344cc2a2390f694ab73335
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version hash has leading whitespace which should be removed. The line should start directly with the hash without any spaces or tabs.

Copilot uses AI. Check for mistakes.
@danepowell danepowell merged commit 6695493 into acquia:main Dec 16, 2025
25 of 26 checks passed
@github-actions
Copy link

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1945/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1945/acli.phar
chmod +x acli.phar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant