Add automatic Retry to Add-to-project action #700
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwick
added
enhancement
Contributor
|
@zwick Were you planning to get this PR ready for review? I think you may need to update the package.json and lock file. |
zwick
force-pushed
the
zwick/add-retries
branch
2 times, most recently
from
8621a20 to
3b6cd34
Compare
Author
|
@skw My efforts are a bit stuck at the moment. The failures in these tests are accurate, we are having some Typescript compatibilities between the Retry plugin and the version of Octokit Core bundled with I'm currently down a bit of a rabbit hole while attempting to leverage This won't be ready until this can be solved, but I'm trying to not spend an exceeding amount of time on it. |
Closed
zwick
force-pushed
the
zwick/add-retries
branch
from
3b6cd34 to
5a29fc9
Compare
zwick
changed the title
zwick
force-pushed
the
zwick/add-retries
branch
from
593f79d to
cba7153
Compare
- Added octokit plugin for automatic retries - Removed un-imported dependency causing version conflicts - Update dist for action with new retry plugin - Update license cache
zwick
force-pushed
the
zwick/add-retries
branch
from
cba7153 to
1f33b7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Users of this action have reported failing tasks due to a race condition with this action. The above linked PR suggested adding a retry capability to the Octokit call. A plugin exists for Octokit to retry failed requests utilizing a standard Backoff and was leveraged for this functionality.
This action is using Octokit Core v6, which required we pin to the Octokit Retry v6 rather than the latest v8.
@octokit/plugin-paginate-resthad an Octokit Core version conflict during an npm install. Our version of Octokit Core installs a sub-dependency of@octokit/plugin-paginate-restthat is not conflictingChanges