-
Notifications
You must be signed in to change notification settings - Fork 1.4k
chore: Make home roller title more responsive #9317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| flexDirection: 'column', | ||
| whiteSpace: 'nowrap' | ||
| whiteSpace: 'nowrap', | ||
| height: '[1.2em]', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ensures a gap between items so they don't bleed into each other with descenders
|
Build successful! 🎉 |
|
it'd be nice if there was a fade like we have in the ToC when there's scrolling but not something that we need for release |
|
# Conflicts: # packages/dev/s2-docs/pages/s2/home/Home.tsx
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
## API Changes
@react-spectrum/s2/@react-spectrum/s2:Image Image {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
alt?: string
- children?: ReactNode
crossOrigin?: 'anonymous' | 'use-credentials'
decoding?: 'async' | 'auto' | 'sync'
fetchPriority?: 'high' | 'low' | 'auto'
group?: ImageGroup
height?: number
- itemProp?: string
loading?: 'eager' | 'lazy'
referrerPolicy?: HTMLAttributeReferrerPolicy
renderError?: () => ReactNode
slot?: string | null
styles?: StyleString
width?: number
}/@react-spectrum/s2:ImageProps ImageProps {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
alt?: string
- children?: ReactNode
crossOrigin?: 'anonymous' | 'use-credentials'
decoding?: 'async' | 'auto' | 'sync'
fetchPriority?: 'high' | 'low' | 'auto'
group?: ImageGroup
height?: number
- itemProp?: string
loading?: 'eager' | 'lazy'
referrerPolicy?: HTMLAttributeReferrerPolicy
renderError?: () => ReactNode
slot?: string | null
styles?: StyleString
width?: number
} |
yihuiliao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, also tested with reduce motion
Closes
Visit S2 home page and watch the title. Try it on desktop and mobile and possibly in responsive view.
Note, do we want it to pause for small screens? This implementation can support if the roller is on the next line as well.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: