Skip to content

Conversation

@snowystinger
Copy link
Member

@snowystinger snowystinger commented Dec 10, 2025

Closes

Visit S2 home page and watch the title. Try it on desktop and mobile and possibly in responsive view.

Note, do we want it to pause for small screens? This implementation can support if the roller is on the next line as well.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

flexDirection: 'column',
whiteSpace: 'nowrap'
whiteSpace: 'nowrap',
height: '[1.2em]',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ensures a gap between items so they don't bleed into each other with descenders

@rspbot
Copy link

rspbot commented Dec 10, 2025

@yihuiliao
Copy link
Member

it'd be nice if there was a fade like we have in the ToC when there's scrolling but not something that we need for release

@dannify
Copy link
Member

dannify commented Dec 10, 2025

  • Make sure it bails for reduce motion settings
  • Freeze the "with"
  • Use Devon's font size clamping

@rspbot
Copy link

rspbot commented Dec 11, 2025

@rspbot
Copy link

rspbot commented Dec 11, 2025

@rspbot
Copy link

rspbot commented Dec 11, 2025

@rspbot
Copy link

rspbot commented Dec 11, 2025

@rspbot
Copy link

rspbot commented Dec 11, 2025

## API Changes

@react-spectrum/s2

/@react-spectrum/s2:Image

 Image {
   UNSAFE_className?: UnsafeClassName
   UNSAFE_style?: CSSProperties
   alt?: string
-  children?: ReactNode
   crossOrigin?: 'anonymous' | 'use-credentials'
   decoding?: 'async' | 'auto' | 'sync'
   fetchPriority?: 'high' | 'low' | 'auto'
   group?: ImageGroup
   height?: number
-  itemProp?: string
   loading?: 'eager' | 'lazy'
   referrerPolicy?: HTMLAttributeReferrerPolicy
   renderError?: () => ReactNode
   slot?: string | null
   styles?: StyleString
   width?: number
 }

/@react-spectrum/s2:ImageProps

 ImageProps {
   UNSAFE_className?: UnsafeClassName
   UNSAFE_style?: CSSProperties
   alt?: string
-  children?: ReactNode
   crossOrigin?: 'anonymous' | 'use-credentials'
   decoding?: 'async' | 'auto' | 'sync'
   fetchPriority?: 'high' | 'low' | 'auto'
   group?: ImageGroup
   height?: number
-  itemProp?: string
   loading?: 'eager' | 'lazy'
   referrerPolicy?: HTMLAttributeReferrerPolicy
   renderError?: () => ReactNode
   slot?: string | null
   styles?: StyleString
   width?: number
 }

Copy link
Member

@yihuiliao yihuiliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, also tested with reduce motion

@dannify dannify added this pull request to the merge queue Dec 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 12, 2025
@devongovett devongovett added this pull request to the merge queue Dec 12, 2025
Merged via the queue into main with commit c80e3d1 Dec 12, 2025
32 checks passed
@devongovett devongovett deleted the make-home-roller-title-more-responsive branch December 12, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants