Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions src/pymgrid/envs/base/base.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import numpy as np
import pandas as pd
import warnings

from collections import OrderedDict
from gym import Env
Expand Down Expand Up @@ -122,7 +123,19 @@ def _validate_observation_keys(self, keys):
if net_load_pos.size:
keys[[0, net_load_pos.item()]] = keys[[net_load_pos.item(), 0]]

return keys.tolist()
unique_keys, dupe_keys = [], []

for k in keys:
if k in unique_keys:
dupe_keys.append(k)
continue

unique_keys.append(k)

if dupe_keys:
warnings.warn(f'Found duplicated keys, will be dropped:\n\t{dupe_keys}')

return unique_keys

@abstractmethod
def _get_action_space(self, remove_redundant_actions=False):
Expand All @@ -133,7 +146,12 @@ def _get_observation_space(self):

state_series = self.state_series()

observation_keys = self.observation_keys or state_series.index.get_level_values(-1)
if self.observation_keys is None or len(self.observation_keys) == 0:
observation_keys = state_series.index.get_level_values(-1)
else:
observation_keys = pd.Index(self.observation_keys)

observation_keys = observation_keys.drop_duplicates()

if 'net_load' in observation_keys:
obs_space['general'] = Tuple([Box(low=-np.inf, high=1, shape=(1, ), dtype=np.float64)])
Expand Down
Loading