chore(deps): bump idc-index-data from 23.0.3 to 23.2.7 #373
Conversation
dependabot
bot
added
bot
dependabot
bot
requested a review
from helmut-hoffer-von-ankershoffen
as a code owner
dependabot
bot
added
dependencies
|
@dependabot rebase |
dependabot
bot
force-pushed
the
dependabot/pip/idc-index-data-23.2.7
branch
from
6fced64 to
f13e2c8
Compare
|
@dependabot rebase |
Bumps [idc-index-data](https://github.com/ImagingDataCommons/idc-index-data) from 23.0.3 to 23.2.7. - [Release notes](https://github.com/ImagingDataCommons/idc-index-data/releases) - [Commits](ImagingDataCommons/idc-index-data@23.0.3...23.2.7) --- updated-dependencies: - dependency-name: idc-index-data dependency-version: 23.2.7 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/pip/idc-index-data-23.2.7
branch
from
f13e2c8 to
85670f0
Compare
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
| "html-sanitizer>=2.6.0,<3", | ||
| "httpx>=0.28.1,<1", | ||
| "idc-index-data==23.0.3", | ||
| "idc-index-data==23.2.7", |
There was a problem hiding this comment.
Bug: A failure to download an index file from a GitHub release is not handled with an exception, leading to a runtime error when the None attribute is accessed later.
Severity: CRITICAL
🔍 Detailed Analysis
The fetch_index() method in idc_index.py downloads additional index files, such as sm_instance_index.parquet, from GitHub release assets. If a file is missing from the release, the method logs an error but does not raise an exception. This causes the corresponding attribute, like client.sm_instance_index, to remain None. Subsequent code in _service.py that attempts to use this attribute to download individual DICOM instances will fail with an error, such as an AttributeError. This silent failure during the download process leads to a runtime crash when a core feature is used.
💡 Suggested Fix
Modify the fetch_index() method in idc_index.py to raise an exception if the requests.get() call fails to download an index file (e.g., status code is not 200). This will ensure the failure is caught immediately, rather than silently propagating a None value that causes a downstream crash.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: pyproject.toml#L103
Potential issue: The `fetch_index()` method in `idc_index.py` downloads additional index
files, such as `sm_instance_index.parquet`, from GitHub release assets. If a file is
missing from the release, the method logs an error but does not raise an exception. This
causes the corresponding attribute, like `client.sm_instance_index`, to remain `None`.
Subsequent code in `_service.py` that attempts to use this attribute to download
individual DICOM instances will fail with an error, such as an `AttributeError`. This
silent failure during the download process leads to a runtime crash when a core feature
is used.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 8388379
|
Bumps idc-index-data from 23.0.3 to 23.2.7.
Release notes
Sourced from idc-index-data's releases.
... (truncated)
Commits
44d2976ENH: eliminate redundancy in code to generate indices87ceabcci: remove artifact files from gitignore7f8a240ci: remove parquet files not whitelisted to control package size5e1bf29ci: tell hatch to not use .gitignore for selecting artifacts3857d0abug: reorganize GHA workflows03368fdbug: fix packaging of artifactsbe46ca9bug: fix path for downloaded artifacts25d3edbbug: fix adding package files to wheel9d3347benh: fix copilot identified issues, add index filepath to index metadata2b764a8enh: fix lintingDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)