-
Notifications
You must be signed in to change notification settings - Fork 920
azure-pipelines-rpi: add cloudsmith upload support for rpi artifacts #3053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
amiclaus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall, minor questions.
|
|
||
| #upload artifacts to Cloudsmith | ||
| artifacts_cloudsmith() { | ||
| artifacts_structure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe consider adding set -e?
Add function for cloudsmith support in the prepare_artifacts_rpi.sh script to upload the rpi artifacts. Signed-off-by: Andreea Andrisan <Andreea.Andrisan@analog.com>
4a4eee3 to
dc1e1e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments from me...
I would like to see this separated in two patches. First add the code needed for the job and then enable it in the .yml file.
But the more fundamental question is about @gastmaier CI work. Won't we want this being done as part of that pipeline? I would like, at some point, top get rid of the duplicated CI we have today.
| tar -C ${PWD}/32bit -czvf rpi_latest_boot_32bit.tar.gz . | ||
| tar -C ${PWD}/64bit -czvf rpi_latest_boot_64bit.tar.gz . | ||
| rm -r ./32bit | ||
| rm -r ./64bit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: new line here.
PR Description
Add function for cloudsmith support in the prepare_artifacts_rpi.sh script to upload the rpi artifacts.
PR Type
PR Checklist