Skip to content

Conversation

@AAndrisa
Copy link
Contributor

@AAndrisa AAndrisa commented Dec 16, 2025

PR Description

Add function for cloudsmith support in the prepare_artifacts_rpi.sh script to upload the rpi artifacts.

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have compiled my changes, including the documentation
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly
  • I have provided links for the relevant upstream lore

Copy link
Contributor

@amiclaus amiclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall, minor questions.


#upload artifacts to Cloudsmith
artifacts_cloudsmith() {
artifacts_structure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe consider adding set -e?

Add function for cloudsmith support in the prepare_artifacts_rpi.sh
script to upload the rpi artifacts.

Signed-off-by: Andreea Andrisan <Andreea.Andrisan@analog.com>
Copy link
Collaborator

@nunojsa nunojsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments from me...

I would like to see this separated in two patches. First add the code needed for the job and then enable it in the .yml file.

But the more fundamental question is about @gastmaier CI work. Won't we want this being done as part of that pipeline? I would like, at some point, top get rid of the duplicated CI we have today.

tar -C ${PWD}/32bit -czvf rpi_latest_boot_32bit.tar.gz .
tar -C ${PWD}/64bit -czvf rpi_latest_boot_64bit.tar.gz .
rm -r ./32bit
rm -r ./64bit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: new line here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants