perf(bun): cache plugin versions with TTL to avoid reinstalling on every startup #6826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry startup When plugins use @latest version, the cache check compared 'latest' against the resolved version (e.g., '2.12.2'), which never matched, causing a full reinstall of all plugins on every startup (~20+ seconds). This fix: - Adds timestamp tracking for cached packages - For @latest requests, reuses cached version if installed within 24 hours - Resolves and stores the actual version after installation Reduces startup time from ~21s to <1s for plugin loading.
xammen
changed the title
Collaborator
|
this doesnt seem like a good solution, if this is the issue: Why not just compare to the actual version that we have installed as a fix then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@latest, the cache now tracks timestamps and reuses cached versions for 24 hoursProblem
The cache check compared
'latest'against the resolved version (e.g.,'2.12.2'), which never matched:Solution
_timestampsfield to track when packages were installed@latestrequests, reuse cached version if installed within 24 hours