fix: opencode Remove the symlinkBinary function call that replaces the wrapper script (fixes #7911) #7912
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrapper script in `bin/opencode` already has robust logic to find the correct platform-specific binary by searching through `node_modules`, so we don't need to replace it with a symlink. The postinstall script should only ensure the binary package is installed, not modify the wrapper script.
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
chuckchen
changed the title
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
chuckchen
changed the title
Collaborator
|
/review |
Contributor
|
lgtm |
chuckchen
force-pushed
the
fix/skip-symlink-at-postinstall
branch
from
c09ac8e to
ed6eceb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrapper script in
bin/opencodealready has robust logic to find the correct platform-specific binary by searching throughnode_modules, so we don't need to replace it with a symlink. The postinstall script should only ensure the binary package is installed, not modify the wrapper script.What does this PR do?
It fixes #7911
How did you verify your code works?
The release package is tested in local.