Replace np.in1d with np.isin #4769
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredsonnenwald
requested review from
hpohekar,
mayankansys,
mkundu1,
prmukherj and
seanpearsonuk
as code owners
|
All Contributor License Agreement (CLA) signatures have been captured successfully. Thanks for contributing! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the codebase to replace the deprecated np.in1d function with np.isin to maintain compatibility with NumPy 2.4.0 and later versions, where np.in1d has been removed.
- Single function call replacement from
np.in1dtonp.isinin the mesh connectivity processing logic - Follows NumPy's official migration recommendation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
np.in1dhas been removed as of NumPy 2.4.0, and thusget_connectivitycalls fail with NumPy >= 2.4. This PR fixes the corresponding issue #4768 where this was reported.Change Summary
np.isinis a direct replacement, and so has been substituted for the singlenp.in1dcall I could find in the code.Rationale
This substitution follows the recommendation of the NumPy documentation:
Impact
Restores the functionality of reading the mesh using
CaseFileas described in https://fluent.docs.pyansys.com/version/stable/user_guide/offline/case_file.html.