Address a TODO in DFRayDataFrame::stages
#80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmingchen
changed the title
DFRayDataFrame::stages
Contributor
|
@andygrove can you allow CI for this PR such that we can ensure it validates correctly? If / when it does, I'm happy to get it merged. Thank you for fixing this @vmingchen ! |
andygrove
approved these changes
Mar 11, 2025
Member
andygrove
left a comment
andygrove
left a comment
There was a problem hiding this comment.
Thanks @vmingchen and @robtandy. I will go ahead and merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The additional
transform_bottomis not needed because when walking up the query tree usingtransform_up, by the time we reach aDFRayStageExec, all its child nodes should have already been handled and we are ready to generate the ray stage for thatDFRayStageExecnode. Note thattransform_upwalks the tree in a bottom-up (post-order) fashion.I tested with the TPCH queries and the stages are the same before and after this change.