Skip to content

Fix BinomialBoundsN may divide 0 #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ZENOTME wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix BinomialBoundsN may divide 0 #708

ZENOTME wants to merge 1 commit into from
+13 −12

Conversation

@ZENOTME
Copy link

@ZENOTME ZENOTME commented Jan 1, 2026

Fix #707

leerho
leerho requested changes Jan 5, 2026
View reviewed changes
Copy link
Contributor

@leerho leerho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching the incomplete check on theta!

src/test/java/org/apache/datasketches/thetacommon/BinomialBoundsNTest.java Outdated
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertTrue;
import static org.testng.Assert.fail;
import static org.testng.Assert.*;
Copy link
Contributor

@leerho leerho Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starred imports are discouraged as they create namespace pollution. Especially here, as the number of potential imports under org.testng.Assert.* is quite large.
Please return to the specific imports.
Thanks.

Copy link
Author

@ZENOTME ZENOTME Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@ZENOTME ZENOTME force-pushed the fix_binomial_bounds branch from cfff061 to ad3f061 Compare January 5, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leerho leerho leerho requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BinomialBoundsN may divide 0

2 participants

@ZENOTME @leerho