Skip to content

Conversation

@Kengne-yvana
Copy link
Contributor

@Kengne-yvana Kengne-yvana commented Jan 6, 2026

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@Kengne-yvana
Copy link
Contributor Author

@IOhacker please can you review this PR

@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2422-standardize-aging-v2 branch from bddda1a to 3f5dd9c Compare January 7, 2026 20:35
@IOhacker
Copy link
Contributor

IOhacker commented Jan 7, 2026

@Kengne-yvana please change the title and the PR from this "[#FINERACT-2422] standardize use of aging vs. ageing" to this "FINERACT-2422: standardize use of aging vs. ageing"

@IOhacker
Copy link
Contributor

IOhacker commented Jan 7, 2026

I am not native speaker, I am adding this as a note, because I have found that:

Both aging and ageing are correct, with the difference being regional preference: aging (without the 'e') is standard in American English, while ageing (with the 'e') is preferred in British English, though 'aging' is increasingly common globally.

Reference: https://internet.psych.wisc.edu/wp-content/uploads/532-Master/532-UnitPages/Unit-11/Grammarist_Aging_NoDate.pdf

@Kengne-yvana Kengne-yvana changed the title [#FINERACT-2422] standardize use of aging vs. ageing FINERACT-2422: standardize use of aging vs. ageing Jan 7, 2026
@Kengne-yvana
Copy link
Contributor Author

@IOhacker I only choosed "aging" over "ageing" because , the one with 'e' occurs less.
Thanks

@Kengne-yvana
Copy link
Contributor Author

@IOhacker Please can you review my PR?
Thanks

@IOhacker
Copy link
Contributor

IOhacker commented Jan 7, 2026

LGTM

@IOhacker IOhacker merged commit 61034e6 into apache:develop Jan 8, 2026
34 checks passed
IOhacker added a commit that referenced this pull request Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants