[plan] Support error handling strategy for built-in chat action. #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
priority/major
xintongsong
reviewed
Jan 3, 2026
api/src/test/java/org/apache/flink/agents/api/resource/ResourceDescriptorTest.java
Show resolved
Hide resolved
| response, initial_request_id, model, messages, output_schema, ctx | ||
| ) | ||
| else: # if there is no tool call generated, return chat response directly | ||
| _clear_tool_call_context(ctx.sensory_memory, initial_request_id) |
Contributor
There was a problem hiding this comment.
Do we still need this when using sensory memory?
Comment on lines
252
to
254
| tool_request_event_context = _remove_tool_request_event_context( | ||
| sensory_memory, request_id | ||
| ) |
Contributor
There was a problem hiding this comment.
Same here. Since we're using sensory memory, do we still need to remove the context? This brings an extra memory update.
wenjin272
force-pushed
the
support-chat-retry
branch
5 times, most recently
from
ffeaf91 to
ec29864
Compare
[api] Move agent api to agnets module in java. fix
fix [plan] Refactor built-in chat action in java.
fix [plan] Support error handling strategy for chat action in java. modify default max retries not manually clear sensory memory. fix fix
wenjin272
force-pushed
the
support-chat-retry
branch
from
ec29864 to
9ca2888
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue: #346
Purpose of change
Support retry/fail/ignore error handling strategy when chat occurs exception or response schema is not expected.
Tests
ut & it
API
No
Documentation
doc-neededdoc-not-needed