HBASE-29820 Bump the syntax of velocity template to align with velocity 2.x syntax (addendum: also update bundled_hbase-bootstrap) #7641

mnpoonia · 2026-01-19T09:06:54Z

…th velocity 2.x syntax

stoty

Please update the commit message to the usual format:

HBASE-29820 Addendum Bump the syntax of velocity template to align with velocity 2.x syntax (addendum: also update bundled_hbase-bootstrap)

mnpoonia · 2026-01-19T10:50:42Z

hbase-http/pom.xml

                <bundled_vega>${license.bundles.vega}</bundled_vega>
                <bundled_logo>${license.bundles.logo}</bundled_logo>
-                <bundled_hbase-bootstrap>${license.bundles.bootstrap}</bundled_hbase-bootstrap>
+                <bundled_bootstrap>${license.bundles.bootstrap}</bundled_bootstrap>


Reference - da824c8

mnpoonia · 2026-01-19T10:51:48Z

Please update the commit message to the usual format:

HBASE-29820 Addendum Bump the syntax of velocity template to align with velocity 2.x syntax (addendum: also update bundled_hbase-bootstrap)

Thank you for the suggestion. Was not aware about addendum hygiene.

stoty · 2026-01-19T11:22:17Z

Please update the commit message to the usual format:
HBASE-29820 Addendum Bump the syntax of velocity template to align with velocity 2.x syntax (addendum: also update bundled_hbase-bootstrap)

Thank you for the suggestion. Was not aware about addendum hygiene.

I gave you the wrong string. it should have been :
HBASE-29820 Bump the syntax of velocity template to align with velocity 2.x syntax (addendum: also update bundled_hbase-bootstrap)

i.e. Use the original commit message for the first part, withough the starting Addendum

Apache-HBase · 2026-01-19T11:22:48Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 28s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	3m 22s		master passed
+1 💚	compile	0m 24s		master passed
+1 💚	javadoc	0m 16s		master passed
+1 💚	shadedjars	5m 52s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 1s		the patch passed
+1 💚	compile	0m 18s		the patch passed
+1 💚	javac	0m 18s		the patch passed
+1 💚	javadoc	0m 12s		the patch passed
+1 💚	shadedjars	5m 47s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 54s		hbase-http in the patch passed.
		21m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7641/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7641
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 907026b46755 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7040188`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7641/2/testReport/
Max. process+thread count	379 (vs. ulimit of 30000)
modules	C: hbase-http U: hbase-http
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7641/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2026-01-19T11:31:05Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 28s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ master Compile Tests _
+1 💚	mvninstall	3m 29s		master passed
+1 💚	compile	0m 35s		master passed
+1 💚	spotless	0m 54s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 11s		the patch passed
+1 💚	compile	0m 25s		the patch passed
+1 💚	javac	0m 25s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	xmllint	0m 0s		No new issues.
+1 💚	hadoopcheck	12m 13s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	0m 47s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 11s		The patch does not generate ASF License warnings.
		29m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7641/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7641
Optional Tests	dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile
uname	Linux 124899f6431b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7040188`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-http U: hbase-http
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7641/2/console
versions	git=2.34.1 maven=3.9.8 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

…ty 2.x syntax (addendum: also update bundled_hbase-bootstrap)

Apache-HBase · 2026-01-19T13:20:39Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 14s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	2m 47s		master passed
+1 💚	compile	0m 12s		master passed
+1 💚	javadoc	0m 10s		master passed
+1 💚	shadedjars	4m 15s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 13s		the patch passed
+1 💚	compile	0m 13s		the patch passed
+1 💚	javac	0m 13s		the patch passed
+1 💚	javadoc	0m 9s		the patch passed
+1 💚	shadedjars	4m 14s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 41s		hbase-http in the patch passed.
		17m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7641/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7641
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c9b28259132e 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `42cb96d`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7641/3/testReport/
Max. process+thread count	318 (vs. ulimit of 30000)
modules	C: hbase-http U: hbase-http
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7641/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2026-01-19T13:25:11Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 20s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ master Compile Tests _
+1 💚	mvninstall	2m 38s		master passed
+1 💚	compile	0m 20s		master passed
+1 💚	spotless	0m 41s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 10s		the patch passed
+1 💚	compile	0m 18s		the patch passed
+1 💚	javac	0m 18s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	xmllint	0m 0s		No new issues.
+1 💚	hadoopcheck	8m 17s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	0m 32s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 8s		The patch does not generate ASF License warnings.
		21m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7641/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7641
Optional Tests	dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile
uname	Linux bdc99d2881c1 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `42cb96d`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-http U: hbase-http
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7641/3/console
versions	git=2.34.1 maven=3.9.8 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

stoty

+1 LGTM

…ty 2.x syntax (addendum: also update bundled_hbase-bootstrap) (#7641) Signed-off-by: Istvan Toth <stoty@apache.org> (cherry picked from commit 2741727)

This comment has been minimized.

Sign in to view

stoty requested changes Jan 19, 2026

View reviewed changes

mnpoonia force-pushed the master branch from da9a5d9 to 7040188 Compare January 19, 2026 10:49

mnpoonia commented Jan 19, 2026

View reviewed changes

mnpoonia changed the title ~~HBASE-29820 Addendum Bump the syntax of velocity template to align wi…~~ HBASE-29820 Addendum Bump the syntax of velocity template to align with velocity 2.x syntax (addendum: also update bundled_hbase-bootstrap) Jan 19, 2026

HBASE-29820 Bump the syntax of velocity template to align with veloci…

42cb96d

…ty 2.x syntax (addendum: also update bundled_hbase-bootstrap)

mnpoonia force-pushed the master branch from 7040188 to 42cb96d Compare January 19, 2026 12:57

stoty approved these changes Jan 19, 2026

View reviewed changes

stoty merged commit 2741727 into apache:master Jan 20, 2026
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-29820 Bump the syntax of velocity template to align with velocity 2.x syntax (addendum: also update bundled_hbase-bootstrap) #7641

HBASE-29820 Bump the syntax of velocity template to align with velocity 2.x syntax (addendum: also update bundled_hbase-bootstrap) #7641

mnpoonia commented Jan 19, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

stoty left a comment

Uh oh!

mnpoonia Jan 19, 2026

Uh oh!

mnpoonia commented Jan 19, 2026

Uh oh!

stoty commented Jan 19, 2026

Uh oh!

Apache-HBase commented Jan 19, 2026

Uh oh!

Apache-HBase commented Jan 19, 2026

Uh oh!

Apache-HBase commented Jan 19, 2026

Uh oh!

Apache-HBase commented Jan 19, 2026

Uh oh!

stoty left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HBASE-29820 Bump the syntax of velocity template to align with velocity 2.x syntax (addendum: also update bundled_hbase-bootstrap) #7641

HBASE-29820 Bump the syntax of velocity template to align with velocity 2.x syntax (addendum: also update bundled_hbase-bootstrap) #7641

Conversation

mnpoonia commented Jan 19, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

stoty left a comment

Choose a reason for hiding this comment

Uh oh!

mnpoonia Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

mnpoonia commented Jan 19, 2026

Uh oh!

stoty commented Jan 19, 2026

Uh oh!

Apache-HBase commented Jan 19, 2026

Uh oh!

Apache-HBase commented Jan 19, 2026

Uh oh!

Apache-HBase commented Jan 19, 2026

Uh oh!

Apache-HBase commented Jan 19, 2026

Uh oh!

stoty left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants