HBASE-29835: Fix typos and inconsistencies in CacheAwareLoadBalancer #7644
+6
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfrancke
commented
Jan 19, 2026
| LOG.debug( | ||
| "Region {} not moved from {} to {} with current cache ratio {} and old cache ratio {}", | ||
| cluster.regions[regionIndex], cluster.servers[currentServerIndex], | ||
| cluster.servers[oldServerIndex], cacheRatioOnCurrentServer, |
Member
Author
There was a problem hiding this comment.
Note that it would log current server ratio twice.
lfrancke
commented
Jan 19, 2026
| "Region {} moved from {} to {} as region cache ratio {} is better than the current " | ||
| + "cache ratio {}", | ||
| cluster.regions[regionIndex].getEncodedName(), cluster.servers[currentServerIndex], | ||
| cluster.servers[oldServerIndex], cacheRatioOnCurrentServer, |
Member
Author
There was a problem hiding this comment.
Note that it would log current ratio twice
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
wchevreuil
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HBASE-28804 also introduced a
DecimalFormatwhich is only used in a debug statement but instantiated once per call to a method. It is also inconsistently used.I decided to remove it entirely in my PR. Another option would be to introduce it everywhere. I'm fine either way.