feat: implement direct Avro encoder for performance #445
+1,002
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shangxinli
force-pushed
the
avro_writer
branch
from
e9c1cbc to
2fec4dd
Compare
Implement direct Avro encoder to eliminate GenericDatum intermediate layer, matching the decoder approach for better performance. Implementation: - Add avro_direct_encoder_internal.h with EncodeArrowToAvro API - Add avro_direct_encoder.cc implementing direct Arrow→Avro encoding - All primitive types: bool, int, long, float, double, string, binary - Temporal types: date, time, timestamp - Logical types: uuid, decimal - Nested types: struct, list, map (both string and non-string keys) - Union type handling for optional fields - Modify avro_writer.cc to use DataFileWriterBase with direct encoder - Add EncodeContext to reuse scratch buffers and avoid allocations This matches Java Iceberg implementation using Encoder interface directly, avoiding intermediate object allocation overhead.
shangxinli
force-pushed
the
avro_writer
branch
from
2fec4dd to
8128b17
Compare
wgtmac
reviewed
Dec 29, 2025
Member
wgtmac
left a comment
wgtmac
left a comment
There was a problem hiding this comment.
I haven't finished my review yet, just post my findings so far.
Comment on lines
+46
to
+57
| /// methods from Arrow arrays. Matches Java Iceberg's approach for better performance. | ||
| /// | ||
| /// Features: | ||
| /// - All primitive, temporal, and logical types | ||
| /// - Nested types (struct, list, map) | ||
| /// - Union types for optional fields | ||
| /// | ||
| /// Error Handling: | ||
| /// - Type mismatches → InvalidArgument | ||
| /// - Null in non-nullable field → InvalidArgument | ||
| /// - Invalid decimal precision → InvalidArgument | ||
| /// |
Member
There was a problem hiding this comment.
Suggested change
| /// methods from Arrow arrays. Matches Java Iceberg's approach for better performance. | |
| /// | |
| /// Features: | |
| /// - All primitive, temporal, and logical types | |
| /// - Nested types (struct, list, map) | |
| /// - Union types for optional fields | |
| /// | |
| /// Error Handling: | |
| /// - Type mismatches → InvalidArgument | |
| /// - Null in non-nullable field → InvalidArgument | |
| /// - Invalid decimal precision → InvalidArgument | |
| /// | |
| /// methods from Arrow arrays. | |
| /// |
| inline static Entry<int64_t> kAvroSyncInterval{"write.avro.sync-interval", 16 * 1024}; | ||
|
|
||
| /// \brief Whether to skip GenericDatum and use direct encoder for Avro writing. | ||
| /// When true, uses direct encoder (faster). When false, uses GenericDatum (legacy). |
Member
There was a problem hiding this comment.
Suggested change
| /// When true, uses direct encoder (faster). When false, uses GenericDatum (legacy). | |
| /// When true, uses direct encoder (faster). When false, uses GenericDatum. |
| Status EncodeArrowToAvro(const ::avro::NodePtr& avro_node, ::avro::Encoder& encoder, | ||
| const Type& type, const ::arrow::Array& array, int64_t row_index, | ||
| EncodeContext* ctx) { | ||
| if (!ctx) { |
Member
There was a problem hiding this comment.
I just noticed that we haven't checked null for DecodeContext* ctx in the decoder implementation. Can we use DecodeContext& and EncodeContext& ctx so we don't need to bother with null check?
| const size_t num_fields = avro_node->leaves(); | ||
|
|
||
| for (size_t i = 0; i < num_fields; ++i) { | ||
| const auto& field_node = avro_node->leafAt(i); |
Member
There was a problem hiding this comment.
Do we need to check if num of fields mismatch between arrow array and avro node?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement direct Avro encoder to eliminate GenericDatum intermediate layer, matching the decoder approach for better performance.
Implementation:
This matches Java Iceberg implementation using Encoder interface directly, avoiding intermediate object allocation overhead.