-
Notifications
You must be signed in to change notification settings - Fork 254
feat(python): add AsyncIterator interface to IggyConsumer #2552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
slbotbm
wants to merge
8
commits into
apache:master
Choose a base branch
from
slbotbm:extend-consumer-group-interface
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a `.iter()` method for asynchronously iterating over Iggy messages from a consumer. Adding this method requires the consumer group to be initialized so `consumer_group` is made async and initialization is made upfront. `partition_id` is also exposed on `ReceiveMessage` to allow manual commit of offsets.
25acc33 to
9df56c8
Compare
slbotbm
commented
Jan 13, 2026
Comment on lines
+133
to
+143
| /// Asynchronously iterate over `ReceiveMessage`s. | ||
| /// | ||
| /// Returns an async iterator that raises `StopAsyncIteration` when no more messages are available | ||
| /// or a `PyRuntimeError` on failure. | ||
| /// | ||
| /// Note: This method does not currently support `AutoCommit.After`. | ||
| /// For `AutoCommit.IntervalOrAfter(datetime.timedelta, AutoCommitAfter)`, | ||
| /// only the interval part is applied; the `after` mode is ignored. | ||
| /// Use `consume_messages()` if you need commit-after-processing semantics. | ||
| #[gen_stub(override_return_type(type_repr="collections.abc.AsyncIterator[ReceiveMessage]", imports=("collections.abc")))] | ||
| fn iter_messages<'a>(&self) -> ReceiveMessageIterator { |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only part that has been changed by me (the function name + note doc). The rest is the same as the original PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuing the work of #2169