refactor(server): consolidate permissions into metadata crate and fix inheritance bugs #2564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubcio
force-pushed
the
permissions-test
branch
7 times, most recently
from
bb45739 to
a85c8c7
Compare
… inheritance bugs Permission checks were scattered across system layer, making enforcement inconsistent. Moving them to handlers where auth context lives and using metadata crate as single source of truth improves clarity. Fixed broken inheritance - manage_stream now properly implies read_stream, and similar fixes throughout the hierarchy. Added resolve_* helpers to consolidate existence checks with ID resolution, eliminating verbose repeated patterns in handlers. Lastly, comprehensive permissions integration test was added.
hubcio
force-pushed
the
permissions-test
branch
from
49f9776 to
036b4ef
Compare
krishvishal
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permission checks were scattered across system layer,
making enforcement inconsistent. Moving them to
handlers where auth context lives and using metadata
crate as single source of truth improves clarity.
Fixed broken inheritance - manage_stream now properly
implies read_stream, and similar fixes throughout the hierarchy.
Added resolve_* helpers to consolidate existence checks
with ID resolution, eliminating verbose repeated patterns
in handlers.
Lastly, comprehensive permissions integration test was added.