fix(server): prevent message unavailability during background persistence #2578
+192
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ence Messages were unavailable when background message_saver committed the journal (emptying it) and started async disk I/O before completion. Polling during this window found neither journal nor disk data. The fix freezes journal batches and sets them in the in-flight buffer before async persist. Readers now merge in-flight data with segments, maintaining availability throughout the disk write operation.
hubcio
force-pushed
the
fix-persistence-read
branch
from
e7dd793 to
c9a2d3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messages were unavailable when background message_saver committed the
journal (emptying it) and started async disk I/O before completion.
Polling during this window found neither journal nor disk data.
The fix freezes journal batches and sets them in the in-flight buffer
before async persist. Readers now merge in-flight data with segments,
maintaining availability throughout the disk write operation.