Skip to content

[QDP] Fix Route Error in Makefile #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guan404ming merged 1 commit into from
Dec 31, 2025
Merged

[QDP] Fix Route Error in Makefile #775

guan404ming merged 1 commit into from
Dec 31, 2025
+1 −1

Conversation

@rich7420
Copy link
Contributor

@rich7420 rich7420 commented Dec 31, 2025

Purpose of PR

as title

error:
make install_benchmark

cd qdp/qdp-python && uv sync --group benchmark
/bin/sh: 1: cd: can't cd to qdp/qdp-python
make: *** [Makefile:46: install_benchmark] Error 2

Related Issues or PRs

Changes Made

  • Bug fix
  • New feature
  • Refactoring
  • Documentation
  • Test
  • CI/CD pipeline
  • Other

Breaking Changes

  • Yes
  • No

Checklist

  • Added or updated unit tests for all changes
  • Added or updated documentation for all changes
  • Successfully built and ran all unit tests or manual tests locally
  • PR title follows "MAHOUT-XXX: Brief Description" format (if related to an issue)
  • Code follows ASF guidelines

@rich7420 rich7420 self-assigned this Dec 31, 2025
@rich7420 rich7420 added the qdp label Dec 31, 2025
@github-project-automation github-project-automation bot moved this to Backlog in QDP Dec 31, 2025
ryankert01
ryankert01 approved these changes Dec 31, 2025
View reviewed changes
Copy link
Contributor

@ryankert01 ryankert01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryankert01
Copy link
Contributor

ryankert01 commented Dec 31, 2025

nice patch

400Ping
400Ping approved these changes Dec 31, 2025
View reviewed changes
Copy link
Contributor

@400Ping 400Ping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guan404ming guan404ming merged commit db71abf into apache:dev-qdp Dec 31, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in QDP Dec 31, 2025
guan404ming pushed a commit that referenced this pull request Jan 6, 2026
@rich7420 @guan404ming
[QDP] Fix Route Error in Makefile (#775)
333b3e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guan404ming guan404ming guan404ming approved these changes

+2 more reviewers

@400Ping 400Ping 400Ping approved these changes

@ryankert01 ryankert01 ryankert01 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rich7420 rich7420

Labels

qdp

Projects

QDP
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rich7420 @ryankert01 @400Ping @guan404ming