-
Notifications
You must be signed in to change notification settings - Fork 1.4k
net/tcp: tcp header seq check #17691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wenquan2015
wants to merge
8
commits into
apache:master
Choose a base branch
from
wenquan2015:6174677
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+128
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The Change ID should be removed from the commit message. Do you have any idea why this PR did not trigger the CI? @simbit18 |
Contributor
The first pr from new contributor need be approved manually to filter the garbage patch. |
…th OTW SEQ number in SYN-RCVD state According rfc793 p69, In SYN-RCVD state, if the incoming segment is not acceptable, an acknowledgment should be sent in reply (unless the RST bit is set): <SEQ=SND.NXT><ACK=RCV.NXT><CTL=ACK> Signed-off-by: wenquan1 <wenquan1@xiaomi.com>
… number except SYN-SEND state According rfc793 p69, from state SYN-RECEIVED to state TIME-WAIT, if the incoming segment is not acceptable, an acknowledgment should be sent in reply (unless the RST bit is set): <SEQ=SND.NXT><ACK=RCV.NXT><CTL=ACK> Signed-off-by: wenquan1 <wenquan1@xiaomi.com>
… then enter the closed state According rfc793 p71, after step1 check OTW seq, and step2 check RST flag, then check syn flag. Signed-off-by: wenquan1 <wenquan1@xiaomi.com>
…-send state ignore a segment carrying an unacceptable ACK and RST in syn-send state Signed-off-by: wenquan1 <wenquan1@xiaomi.com>
Signed-off-by: wenquan1 <wenquan1@xiaomi.com>
… state Signed-off-by: wenquan1 <wenquan1@xiaomi.com>
Signed-off-by: wenquan1 <wenquan1@xiaomi.com>
Signed-off-by: wenquan1 <wenquan1@xiaomi.com>
xiaoxiang781216
approved these changes
Dec 26, 2025
Contributor
|
@wenquan2015 please fix: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Check tcp header sndseq and ackseq according to RFC 793.
Impact
tcp
Testing
enable iperf,check iperf test ok