Replace uses of StringBuffer with StringBuilder. #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StringBuffer is a legacy synchronized class. StringBuilder is a direct replacement to StringBuffer which generally have better performance. It's quite important for performance in fresh versions of Java which disabled/removed biased locking.
elharo
reviewed
Aug 12, 2025
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
This PR might be correct, but FYI StringBuilder is not a direct replacement for StringBuffer. It's fine for local variables that don't escape method scope. Other usages need careful consideration of whether the synchronization properties are important.
elharo
reviewed
Aug 12, 2025
| private StringBuilder getListOfEnums() | ||
| { | ||
| StringBuffer enumNamesList = new StringBuffer(); | ||
| StringBuilder enumNamesList = new StringBuilder(); |
|
|
||
| public static void printUsage() { | ||
| StringBuffer vers = new StringBuffer("XSLTC version " + VERSION_MAJOR | ||
| StringBuilder vers = new StringBuilder("XSLTC version " + VERSION_MAJOR |
There was a problem hiding this comment.
This one's weird. It should probably just use a String, or maybe use append, but really a String is all that's needed; neither StringBuilder nor StringBuffer is appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringBuffer is a legacy synchronized class. StringBuilder is a direct replacement to StringBuffer which generally have better performance. It's quite important for performance in fresh versions of Java which disabled/removed biased locking.
mvn verify