Skip to content

[XMLBeans-483] further perf optimisation in array setter #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pjfanning wants to merge 1 commit into from
Closed

[XMLBeans-483] further perf optimisation in array setter #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions src/main/java/org/apache/xmlbeans/impl/values/XmlComplexContentImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,19 +407,20 @@ protected void arraySetterHelper(XmlObject[] sources, QName elemName, QNameSet s
m = startPos;
}

int j;
for (i = startSrc, j = startDest; i < n; i++, j++) {
TypeStoreUser user;

if (j >= m) {
user = store.add_element_user(elemName);
} else if (set == null) {
user = store.find_element_user(elemName, j);
} else {
user = store.find_element_user(set, j);
}
final int size = Math.min(m - startDest, sources.length - startSrc);
ArrayList<XmlObjectBase> users = new ArrayList<>(size);
if (set == null) {
store.find_multiple_element_users(elemName, users, size);
} else {
store.find_multiple_element_users(set, users, size);
}
i = startSrc;
for (XmlObjectBase user : users) {
user.set(sources[i++]);
}

((XmlObjectBase) user).set(sources[i]);
for (TypeStoreUser u : store.add_elements_users(elemName, n - i)) {
((XmlObjectBase) u).set(sources[i++]);
}

// We can't just delegate to array_setter because we need
Expand Down
Loading