Skip to content

test: cover exception if property is null for filters #7716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soyuka merged 1 commit into from
Jan 29, 2026
Merged

test: cover exception if property is null for filters #7716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/Fixtures/TestBundle/Document/Chicken.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,15 @@
normalizationContext: ['hydra_prefix' => false],
parameters: [
'chickenCoop' => new QueryParameter(filter: new IriFilter()),
'chickenCoopNoProperty' => new QueryParameter(filter: new IriFilter()),
'chickenCoopId' => new QueryParameter(filter: new ExactFilter(), property: 'chickenCoop'),
'name' => new QueryParameter(filter: new ExactFilter()),
'nameExactNoProperty' => new QueryParameter(filter: new ExactFilter()),
'namePartial' => new QueryParameter(
filter: new PartialSearchFilter(),
property: 'name',
),
'namePartialNoProperty' => new QueryParameter(filter: new PartialSearchFilter()),
'autocomplete' => new QueryParameter(filter: new FreeTextQueryFilter(new OrFilter(new ExactFilter())), properties: ['name', 'ean']),
'q' => new QueryParameter(filter: new FreeTextQueryFilter(new PartialSearchFilter()), properties: ['name', 'ean']),
],
Expand Down
3 changes: 3 additions & 0 deletions tests/Fixtures/TestBundle/Entity/Chicken.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,15 @@
normalizationContext: ['hydra_prefix' => false],
parameters: [
'chickenCoop' => new QueryParameter(filter: new IriFilter()),
'chickenCoopNoProperty' => new QueryParameter(filter: new IriFilter()),
'chickenCoopId' => new QueryParameter(filter: new ExactFilter(), property: 'chickenCoop'),
'name' => new QueryParameter(filter: new ExactFilter()),
'nameExactNoProperty' => new QueryParameter(filter: new ExactFilter()),
'namePartial' => new QueryParameter(
filter: new PartialSearchFilter(),
property: 'name',
),
'namePartialNoProperty' => new QueryParameter(filter: new PartialSearchFilter()),
'autocomplete' => new QueryParameter(filter: new FreeTextQueryFilter(new OrFilter(new ExactFilter())), properties: ['name', 'ean']),
'q' => new QueryParameter(filter: new FreeTextQueryFilter(new PartialSearchFilter()), properties: ['name', 'ean']),
],
Expand Down
15 changes: 15 additions & 0 deletions tests/Functional/Parameters/ExactFilterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,21 @@ public static function exactSearchFilterProvider(): \Generator
];
}

public function testExactSearchFilterThrowsExceptionWhenPropertyIsMissing(): void
{
$response = self::createClient()->request('GET', '/chickens?nameExactNoProperty=Gertrude');
$this->assertResponseStatusCodeSame(400);

$responseData = $response->toArray(false);

$this->assertSame('An error occurred', $responseData['hydra:title']);
$this->assertSame($responseData['hydra:description'], $responseData['detail']);
$this->assertStringContainsString(
'The filter parameter with key "nameExactNoProperty" must specify a property',
$responseData['detail']
);
}

/**
* @throws \Throwable
* @throws MongoDBException
Expand Down
15 changes: 15 additions & 0 deletions tests/Functional/Parameters/IriFilterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,21 @@ public function testIriFilterMultiple(): void
$this->assertCount(2, $res['member']);
}

public function testIriFilterThrowsExceptionWhenPropertyIsMissing(): void
{
$response = self::createClient()->request('GET', '/chickens?chickenCoopNoProperty=/chicken_coops/1');
$this->assertResponseStatusCodeSame(400);

$responseData = $response->toArray(false);

$this->assertSame('An error occurred', $responseData['hydra:title']);
$this->assertSame($responseData['hydra:description'], $responseData['detail']);
$this->assertStringContainsString(
'The filter parameter with key "chickenCoopNoProperty" must specify a property',
$responseData['detail']
);
}

/**
* @throws \Throwable
*/
Expand Down
15 changes: 15 additions & 0 deletions tests/Functional/Parameters/PartialSearchFilterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,21 @@ public static function partialSearchMultiByteFilterProvider(): \Generator
];
}

public function testPartialSearchFilterThrowsExceptionWhenPropertyIsMissing(): void
{
$response = self::createClient()->request('GET', '/chickens?namePartialNoProperty=ertrude');
$this->assertResponseStatusCodeSame(400);

$responseData = $response->toArray(false);

$this->assertSame('An error occurred', $responseData['hydra:title']);
$this->assertSame($responseData['hydra:description'], $responseData['detail']);
$this->assertStringContainsString(
'The filter parameter with key "namePartialNoProperty" must specify a property',
$responseData['detail']
);
}

/**
* @throws \Throwable
* @throws MongoDBException
Expand Down
Loading