Skip to content

Conversation

@tabrisnet
Copy link
Contributor

@tabrisnet tabrisnet commented Dec 8, 2025

This has been discussed in #25 & is one [partial?] solution to #28.
Specifically, we cannot pull in armbian-bsp into the rootfs. We want to install it a bit later in the armbian/build image process, and in fact that is already done [no change is needed in armbian/build].

@coderabbitai
Copy link

coderabbitai bot commented Dec 8, 2025

Walkthrough

This change modifies the debian/control file for the armbian-common package. The dependency on armbian-bsp or armbian-bsp-cli (specified as armbian-bsp|armbian-bsp-cli) has been moved from the Depends field to the Suggests field. This transitions the dependency from mandatory to optional, changing the default installation behavior while maintaining the relationship in the package metadata.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single file modification with a straightforward dependency metadata move
  • Verify the dependency identifier was correctly transferred to the Suggests field
  • Confirm debian/control syntax remains valid and no unintended lines were modified
  • Ensure this behavioral change aligns with the package's intended design

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: moving armbian-bsp from Depends to Suggests in the control file for armbian-common.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description clearly relates to the changeset by explaining the rationale for moving armbian-bsp from Depends to Suggests in debian/control.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added 02 Milestone: First quarter release size/small PR with less then 50 lines Needs review Seeking for review and removed size/small PR with less then 50 lines labels Dec 8, 2025
@tabrisnet tabrisnet requested a review from leggewie December 9, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

02 Milestone: First quarter release Needs review Seeking for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant