fix linking with LDLIBS instead of CFLAGS #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlasky
added a commit
to vlasky/sqlite-vec
that referenced
this pull request
Dec 29, 2025
Move the -lm flag from CFLAGS to a new LDLIBS variable and place it at the end of the linker command. This ensures libm is properly linked on Linux systems. The linker processes arguments left-to-right, so library flags must come after source files that reference their symbols. Previously, -lm appeared before the source file, causing "undefined symbol: sqrtf" errors on some Linux distributions. Cherry-picked from upstream PR asg017#252 Co-Authored-By: wardviaene <ward.viaene@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #84
The downloaded asset sqlite-vec-0.1.6-loadable-linux-x86_64.tar.gz has this output from ldd:
The -lm flag needs to be moved to the end. After the change, the ldd output is:
Fixing the dependency on libm, and removing any
undefined symbol: sqrtferrors when downloading the shared library file